-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that cuda::__throw_cuda_error works even on non CUDA compilers #3369
Draft
caugonnet
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
caugonnet:non_cuda_compiler_throw_cuda_error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ensure that cuda::__throw_cuda_error works even on non CUDA compilers #3369
caugonnet
wants to merge
7
commits into
NVIDIA:main
from
caugonnet:non_cuda_compiler_throw_cuda_error
+28
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ok to test |
…ompilers" This reverts commit 15fe5e0.
…ot require defining the cudaError_t type to ignore it
/ok to test |
🟩 CI finished in 2h 35m: Pass: 100%/144 | Total: 1d 11h | Avg: 14m 52s | Max: 1h 12m | Hits: 434%/25124
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 144)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
19 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
Open
1 task
`cuda::stream_ref` does not work without at least including cuda_runtime_api.h We previously guarded this by using a cuda compiler but it should be possible to use this with just a c++ compiler. This makes it so and also adds stream_ref to the host compiler tests. The one caveat is that we need to ensure that we properly provide the cuda include path so the compiler finds cuda_runtime_api.h
/ok to test |
/ok to test |
🟨 CI finished in 2h 17m: Pass: 96%/144 | Total: 2d 15h | Avg: 26m 34s | Max: 1h 20m | Hits: 182%/12652
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 144)
# | Runner |
---|---|
98 | linux-amd64-cpu16 |
19 | linux-amd64-gpu-v100-latest-1 |
16 | windows-amd64-cpu16 |
10 | linux-arm64-cpu16 |
1 | linux-amd64-gpu-h100-latest-1-testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current cuda::__throw_cuda_error is not defined if we do not have a CUDA compiler (even with nvc++ without -cuda), this PR defines it simply throw or terminate a std::runtime_error
Checklist